Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Feb 2007 11:17:26 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Mike Pritchard <mpp@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern subr_witness.c
Message-ID:  <200702061117.27001.jhb@freebsd.org>
In-Reply-To: <200702060551.l165ptc4064006@repoman.freebsd.org>
References:  <200702060551.l165ptc4064006@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 06 February 2007 00:51, Mike Pritchard wrote:
> mpp         2007-02-06 05:51:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             subr_witness.c 
>   Log:
>   The change to the vm_page_queue_freelist lock from a spin lock to a
>   sleep lock missed the witness code, and the system will panic
>   immediately on boot if WITNESS is enabled.
>   
>   Changed the witness definition to the new type.

You had better take it out altogether.  Now you've told witness that this lock 
comes after a spin lock, and that is only going to result in pain and 
suffering.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702061117.27001.jhb>