Date: Sat, 12 Jan 2008 13:03:27 GMT From: Dominic Fandrey <lon_kamikaze@gmx.de> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/119593: [patch][multimedia/mplayer] allow building with distcc and ccache Message-ID: <200801121303.m0CD3RCh035861@www.freebsd.org> Resent-Message-ID: <200801121310.m0CDA1do065864@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119593
>Category: misc
>Synopsis: [patch][multimedia/mplayer] allow building with distcc and ccache
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 12 13:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Dominic Fandrey
>Release: RELENG_7
>Organization:
private
>Environment:
FreeBSD homeKamikaze.norad 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Sun Dec 16 15:44:56 CET 2007 root@homeKamikaze.norad:/usr/obj/VECTRA-7/i386/usr/src/sys/VECTRA-7 i386
>Description:
The port sets CC in a fashion that is not space safe, so if CC is defined with distcc and or ccache the mplayer configure script will fall back to the default.
The patch removes the faulty lines and so lets configure get CC an AR through the environment, which supplies the correct values due to the usual bsd.port.mk magic.
>How-To-Repeat:
# cd /usr/ports/mplayer
# make CC="ccache distcc cc"
>Fix:
diff -Pur multimedia/mplayer.orig/Makefile.shared multimedia/mplayer/Makefile.shared
--- multimedia/mplayer.orig/Makefile.shared 2008-01-12 12:35:12.000000000 +0100
+++ multimedia/mplayer/Makefile.shared 2008-01-12 12:58:46.000000000 +0100
@@ -29,9 +29,7 @@
CONFIGURE_ENV= PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \
PTHREAD_LIBS=${PTHREAD_LIBS} \
TMPDIR="${WRKSRC}"
-CONFIGURE_ARGS= --cc=${CC} \
- --as=${AS} \
- --enable-png \
+CONFIGURE_ARGS= --enable-png \
--enable-menu \
--disable-faad-external \
--disable-vidix-external \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801121303.m0CD3RCh035861>