Date: Sat, 22 Sep 2007 13:13:47 +0800 (KRAST) From: Eugene Grosbein <eugen@grosbein.pp.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints Message-ID: <200709220513.l8M5DlQw002006@grosbein.pp.ru> Resent-Message-ID: <200709220520.l8M5K1YQ064401@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 116536
>Category: kern
>Synopsis: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Sep 22 05:20:00 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Eugene Grosbein
>Release: FreeBSD 6.2-STABLE i386
>Organization:
Svyaz-Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 6.2-STABLE FreeBSD 6.2-STABLE #2: Sun Sep 16 16:54:23 KRAST 2007 eu@grosbein.pp.ru:/home/obj/usr/local/src/sys/DADV i386
>Description:
Changing hint.fd.0.flags has no effect on fdc(4)
>How-To-Repeat:
Try to change hint.fd.0.flags and see no change in behavour
>Fix:
--- sys/dev/fdc/fdc.c.orig 2007-09-15 16:53:23.000000000 +0800
+++ sys/dev/fdc/fdc.c 2007-09-16 16:26:07.000000000 +0800
@@ -1848,6 +1864,7 @@
fd->dev = dev;
fd->fdc = fdc;
fd->fdsu = fdsu;
+ fd->flags = flags;
unit = device_get_unit(dev);
/* Auto-probe if fdinfo is present, but always allow override. */
@@ -1857,7 +1874,7 @@
goto done;
} else {
/* make sure fdautoselect() will be called */
- fd->flags = FD_EMPTY;
+ fd->flags |= FD_EMPTY;
fd->type = type;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709220513.l8M5DlQw002006>