Date: Wed, 25 Apr 2007 22:30:09 GMT From: Chris <wefa2@gmx.de> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP statistics Message-ID: <200704252230.l3PMU93w064572@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/112126; it has been noted by GNATS.
From: Chris <wefa2@gmx.de>
To: bug-followup@FreeBSD.org, Maxim Konovalov <maxim@macomnet.ru>
Cc:
Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP statistics
Date: Thu, 26 Apr 2007 00:00:36 +0200
Hello,
postcriptum - I overlooked one detail of Maxim's patch:
> +static const char *icmpnames[ICMP_MAXTYPE + 1] = {
with this he actually avoids the crash in case of an
out of sync kernel interface (assumed the array gets
automatically zeroed at allocation time - does it ? )
But this still produces a very funny netstat output
with just numbers and no labels. I continue to prefer
my suggestion.
Regards
Christoph Weber-Fahr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704252230.l3PMU93w064572>