Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Aug 2021 19:40:09 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Kristof Provost <kp@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 5b8f07b12f84 - main - Fix -Wformat errors in pfctl on 32-bit architectures
Message-ID:  <BA13C28C-EE20-449F-B4D7-18E14EEB5CC9@FreeBSD.org>
In-Reply-To: <6A084192-562D-404D-9833-51A708FA1BC0@FreeBSD.org>
References:  <202108291531.17TFVoah033310@gitrepo.freebsd.org> <6A084192-562D-404D-9833-51A708FA1BC0@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 29 Aug 2021, at 18:00, Kristof Provost <kp@freebsd.org> wrote:
>=20
> On 29 Aug 2021, at 17:31, Dimitry Andric wrote:
>> The branch main has been updated by dim:
>>=20
>> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D5b8f07b12f8477f1679013d6b3abdab8=
d33c7243
>>=20
>> commit 5b8f07b12f8477f1679013d6b3abdab8d33c7243
>> Author:     Dimitry Andric <dim@FreeBSD.org>
>> AuthorDate: 2021-08-29 15:31:28 +0000
>> Commit:     Dimitry Andric <dim@FreeBSD.org>
>> CommitDate: 2021-08-29 15:31:28 +0000
>>=20
>>    Fix -Wformat errors in pfctl on 32-bit architectures
>>=20
>>    Use PRIu64 to printf(3) uint64_t quantities, otherwise this will =
result
>>    in "error: format specifies type 'unsigned long' but the argument =
has
>>    type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]" on =
32-bit
>>    architectures.
>>=20
>>    Fixes:          80078d9d38fd
>>    MFC after:      1 week
>=20
> Thanks!
>=20
> I was running test builds for a fix, but it is so much more convenient =
when other people fix my mistakes for me.

I was trying buildworld on i386 for something totally unrelated, and ran
into these -Wformat errors so I took the liberty of patching them up
quickly. :)

-Dimitry


--Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYSvGeQAKCRCwXqMKLiCW
oypoAKDix9DoDSRfCE4vcpAZjSAQkIbL8wCeLJKDpgyR8w/axdbSsvA9xG/VTjU=
=eLwf
-----END PGP SIGNATURE-----

--Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BA13C28C-EE20-449F-B4D7-18E14EEB5CC9>