Date: Tue, 30 Jul 2013 13:10:35 GMT From: Andrew Yong <andrew@0x.sg> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/180948: Fix for BCM57780 LEDs in if_bge.c Message-ID: <201307301310.r6UDAZ8R015171@oldred.freebsd.org> Resent-Message-ID: <201307301320.r6UDK0WR090110@freefall.freebsd.org>
index | next in thread | raw e-mail
>Number: 180948 >Category: misc >Synopsis: Fix for BCM57780 LEDs in if_bge.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 30 13:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Andrew Yong >Release: 8.3-RELEASE >Organization: - >Environment: FreeBSD edge.0x.sg 8.3-RELEASE-p8 FreeBSD 8.3-RELEASE-p8 #1: Mon Jul 29 16:54:59 EDT 2013 root@snapshots-8_3-amd64.builders.pfsense.org:/usr/obj.pfSense/usr/pfSensesrc/src/sys/pfSense_SMP.8 amd64 >Description: Activity and Link LEDs do not work on BCM57780 NICs. >How-To-Repeat: Load bge modules. LEDs remain non-functional after warm reboot. >Fix: Fixed in HEAD: http://svnweb.freebsd.org/base/head/sys/dev/bge/if_bge.c?r1=251733&r2=252227 Patch against 8.3-RELENG: --- if_bge.c 2013-07-30 21:01:07.000000000 +0800 +++ if_bge.c 2013-07-30 21:01:27.000000000 +0800 @@ -2030,7 +2030,7 @@ CSR_WRITE_4(sc, BGE_MAC_MODE, val); /* Set misc. local control, enable interrupts on attentions */ - CSR_WRITE_4(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); + BGE_SETBIT(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); #ifdef notdef /* Assert GPIO pins for PHY reset */ Patch attached with submission follows: --- if_bge.c.head 2013-07-30 21:01:07.000000000 +0800 +++ if_bge.c 2013-07-30 21:01:27.000000000 +0800 @@ -2030,7 +2030,7 @@ CSR_WRITE_4(sc, BGE_MAC_MODE, val); /* Set misc. local control, enable interrupts on attentions */ - CSR_WRITE_4(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); + BGE_SETBIT(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); #ifdef notdef /* Assert GPIO pins for PHY reset */ >Release-Note: >Audit-Trail: >Unformatted:home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307301310.r6UDAZ8R015171>