Date: Tue, 4 Mar 2008 19:08:09 +0300 From: Roman Bogorodskiy <novel@FreeBSD.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-bugs@FreeBSD.org, Luigi Rizzo <rizzo@icir.org>, araujo@FreeBSD.org, freebsd-ipfw@FreeBSD.org, Vadim Goncharov <vadimnuclight@tpu.ru>, Oleg Bulyzhin <oleg@FreeBSD.org>, Julian Elischer <julian@elischer.org> Subject: Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE fields Message-ID: <20080304160809.GA73149@underworld.novel.ru> In-Reply-To: <47C4F2D1.5080703@yandex.ru> References: <200802261908.m1QJ8n5N023371@freefall.freebsd.org> <47C4F2D1.5080703@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Andrey V. Elsukov wrote: > araujo@FreeBSD.org wrote: >> Synopsis: [ipfw] [patch] add support to ToS IP PRECEDENCE fields >> Responsible-Changed-From-To: freebsd-bugs->freebsd-ipfw >> Responsible-Changed-By: araujo >> Responsible-Changed-When: Tue Feb 26 19:08:49 UTC 2008 >> Responsible-Changed-Why: Over to maintainer(s). >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D121122 >=20 > Hi, Marcelo. >=20 > I talked to Roman when he submitted his first patch about > it's design. What you think about making TOK_SETIPTOSPRE not > an action, but a modifier? I think it will be much usable. > A syntax example: >=20 > # ipfw add allow iptospre flashover ip from any to any > # ipfw add count iptospre immediate ip from anyt to any > # ipfw add skipto .... >=20 > Also I talked to Roman about extensible variant of this ability. > A syntax example: >=20 > <action> [{modip [DF|TOS|DSCP|TTL]}] <rule body> I agree with you, this syntax looks cleaner, however when I was writing my patches I just needed to have the things working and haven't had much time improving/extending this feature. > Also look into: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/102471 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/103454 >=20 > I added to CC several men who are active in ipfw area. > It will be interested what you think about this? >=20 > --=20 > WBR, Andrey V. Elsukov Roman Bogorodskiy --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHzXPn5nvOfo4+NdURAlnLAJ4vjC3dY+p7rpqmYieIwXYGh8UXlwCdG4ww /HEHBK5HfyPkLqkGhQ4I15A= =cpkK -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080304160809.GA73149>