Date: Thu, 15 May 2008 10:40:04 GMT From: Jaakko Heinonen <jh@saunalahti.fi> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount Message-ID: <200805151040.m4FAe4tP057923@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/122833; it has been noted by GNATS. From: Jaakko Heinonen <jh@saunalahti.fi> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: bug-followup@FreeBSD.org, Ga??l Roualland <gael.roualland@dial.oleane.com>, leon.kos@lecad.fs.uni-lj.si, rodrigc@FreeBSD.org, Yar Tikhiy <yar@comp.chem.msu.su> Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount Date: Thu, 15 May 2008 13:35:39 +0300 Thank you for your quick response. On 2008-05-14, Craig Rodrigues wrote: > On Wed, May 14, 2008 at 06:56:40PM +0000, Craig Rodrigues wrote: > > That fix is wrong. The better fix would be to come up Yes, I probably should have stated more clearly that it was a quick hack. > Actually we have such a function. We need to do to the "snapshot" option > what we do to the "export" option in sys/kern/vfs_export.c. > --- ffs_vfsops.c 26 Mar 2008 20:48:07 -0000 1.340 > +++ ffs_vfsops.c 14 May 2008 21:00:23 -0000 There is also code in vfs_mount.c that sets the MNT_SNAPSHOT flag: (in vfs_donmount()) else if (strcmp(opt->name, "snapshot") == 0) fsflags |= MNT_SNAPSHOT; I wonder if we should add the option removal code also there or remove the "snapshot" handling completely from vfs_donmount(). For me it seems confusing that MNT_SNAPSHOT is first set in vfs_donmount() and then again in file system specific code but the snapshot option string is removed only in file system specific code. Thanks. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805151040.m4FAe4tP057923>