Date: Fri, 27 Feb 2015 10:15:48 -0700 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@FreeBSD.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ed Maste <emaste@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Andrew Turner <andrew@fubar.geek.nz>, Bruce Evans <brde@optusnet.com.au>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r279349 - head/sys/kern Message-ID: <4EB4F8DB-77DC-41CE-9678-1D6710A5F058@bsdimp.com> In-Reply-To: <1425052560.1281.21.camel@freebsd.org> References: <201502270256.t1R2uxnv085328@svn.freebsd.org> <20150227082257.3fb1081c@bender.Home> <20150227202646.I2088@besplex.bde.org> <CAJ5_RoCj_D06WK%2BUVrLXNouu252X-6oaaj68RJoQhDzx_wJyAA@mail.gmail.com> <CAPyFy2AwRzvksD_5EcEU5EEvzR7tB1FOpAYzWc2nLtCnyGzaRQ@mail.gmail.com> <E4396923-9EAD-4FFA-82B9-6831B385CA8E@bsdimp.com> <1425052560.1281.21.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 https://reviews.freebsd.org/D1981 contains the fix. Please continue the conversation there. I believe I fixed everything, including a bug in the original code. Warner > On Feb 27, 2015, at 8:56 AM, Ian Lepore <ian@FreeBSD.org> wrote: >=20 > On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote: >> Sure wish my code review got this much love=E2=80=A6 >>=20 >> Warner >>=20 >=20 > IMO, the biggest problem with phab reviews is advertising them. You = can > guess who might be interested and add them as reviewers. You can try > posting a summary and the url to some mailing list. >=20 > I wonder if it would be useful to have the system itself mail the > summary line of every new review that's created to some list? It = would > probably need to be several lists -- I sure don't want to see every > ports phab that gets created, but getting a single mail for every src > review created wouldn't be too much. >=20 > I don't know if that's a good idea or not, but the reason we reliably > get post-commit reviews is because the changes reliably appear in = front > of everyone's eyes at that point. >=20 > -- Ian >=20 >=20 >>> On Feb 27, 2015, at 8:30 AM, Ed Maste <emaste@FreeBSD.org> wrote: >>>=20 >>> On 27 February 2015 at 10:12, Benjamin Kaduk <bjkfbsd@gmail.com> = wrote: >>>>=20 >>>> As of r278229, the kernel is compiled with -fwrapv, so signed = integer >>>> overflow in the FreeBSD kernel is defined behavior. >>>=20 >>> This is primarily a workaround to accommodate existing code though; >>> it's not a result of an explicit decision that we want to support >>> signed integer overflow. >>>=20 >>> -Ed >>>=20 >>=20 >=20 >=20 --Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJU8KZFAAoJEGwc0Sh9sBEA0V0QAOh9+gYIOUSX7A7lg+W57fQF 4nx9XAuepa5Z7b8HtIiZWZlzjVS68frilns/l18ad4fLkRr6ciZxFA6BMG44m7u3 ih7LdNXOrOdO5NGQurRwO79buFAM4Nojouh6yUkeYjTA8Y2XePiGSILsXqS0jOEi NKGIvDb1lEKoVOFzU86DpcaRczzH2DQg3LBF6SJxTkl05ov0wC6qLhqO2TZ3uUk1 DzRwyq7aTJcVFElrmjVQ70R17mJpqf36xt8G63Tj2TiWaHlSqAmYVy3+uOybzb0i QKxYR1ij5nE6YDsOdQXv0tvH39gDrDy4XkDu+YoKY+QvOPvbb6RZpRGtIWv2tJyB 3TOHi7wDgrs8dNCRNxESMgCwFex7CVf8esFJk1vd8OX9u+qyNDBKLXl5JcH5Nd5a Q3WRO+0nEstDVi8qAH8OrL9xLi7OpgZ5V1Dz5UoNwwYobaLibfYt8zymknCHfOfG Pg/QpUEKVWBiytKm/KXmhNjwN0srypLalbhycM2k40En0DMJHQuvTRMdcDH3+Uyf DDNq+ngNg2u3DsEVUctEcpkVvEv7QvPQsqR0CxN6EZVNRSQ5EuPpiXfLYtPE5hYn Tq0iY9Foxx4K7UgVrYIS0+7QSub4Eky94v1m5yDXa2RdYZEqoRFf2fj/TqzhhRvu gfX1b2WMck6aEcq3saSu =P/Mw -----END PGP SIGNATURE----- --Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EB4F8DB-77DC-41CE-9678-1D6710A5F058>