Date: Fri, 26 Dec 2014 11:53:43 +0000 From: Andrew Turner <andrew@fubar.geek.nz> To: Rui Paulo <rpaulo@me.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ian Lepore <ian@FreeBSD.org> Subject: Re: svn commit: r276187 - head/sys/arm/arm Message-ID: <20141226115343.7abbd2d4@bender> In-Reply-To: <9F69A6CD-D352-4A91-97F6-B3E1FF638211@me.com> References: <201412241712.sBOHCqvW039381@svn.freebsd.org> <20141224222637.03a19e57@bender> <1419460812.1018.157.camel@freebsd.org> <8E8B7FE3-0C97-4A84-BC1D-1C5A0E732D0C@me.com> <1419471084.1018.160.camel@freebsd.org> <9F69A6CD-D352-4A91-97F6-B3E1FF638211@me.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 24 Dec 2014 18:05:47 -0800 Rui Paulo <rpaulo@me.com> wrote: > On Dec 24, 2014, at 17:31, Ian Lepore <ian@FreeBSD.org> wrote: > > In every architecture and every place it's used, or just arm just > > here? > > You're right, it can be found at least in MIPS and amd64. > > > This appears to be an idiom, or at least something that has been > > pasted in identical form in every arch so far. > > The idiom is a bit different in amd64: the variable in the for-loop > isn't immediately reused, but it's a global variable anyway... > That's what I thought deserves a comment. I agree we should add a comment here. It's non-obvious the functions will return the same value across multiple calls. > Regarding the pmap_kenter_temporary(), the first problem is the > function name: it might be a temporary mapping, but the real use is > for crash dumps (I wonder why ACPI abuses this mapping). The other > problem is the fact that a pmap function is so tied to crash dumps. > However, that's a bigger problem. Yes, this functions looks like it needs to be reworked a little but I would have to think about it first. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141226115343.7abbd2d4>