Date: Fri, 4 Jan 2008 12:40:36 -0600 From: Brooks Davis <brooks@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: gonzo@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 132497 for review Message-ID: <20080104184036.GB44815@lor.one-eyed-alien.net> In-Reply-To: <20080104.111926.-108774279.imp@bsdimp.com> References: <200801041711.m04HBGPG029002@repoman.freebsd.org> <20080104.111926.-108774279.imp@bsdimp.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Jan 04, 2008 at 11:19:26AM -0700, M. Warner Losh wrote: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org> > Oleksandr Tymoshenko <gonzo@freebsd.org> writes: > : http://perforce.freebsd.org/chv.cgi?CH=132497 > : > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07 > : > : o I believe MK_ZFS is more appropriate variable to be checked > : in this case. > > I thought this was more a case of 'exclude all CDDL code' rather than > being tied to ZFS. ${MK_CDDL} == "no" absolutely needs to cause ZFS bits to not build. I'm not sure if ${MK_CDDL} == "no" implies ${MK_ZFS} != "no". If so this is OK, if not it isn't. -- Brooks > Warner > > : Affected files ... > : > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit > : > : Differences ... > : > : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko) ==== > : > : @@ -13,7 +13,7 @@ > : > : CFLAGS+=-D_KVM_VNODE > : > : -.if ${MK_CDDL} != "no" > : +.if ${MK_ZFS} != "no" > : CFLAGS+= -DZFS > : OBJS+= zfs/zfs.o > : SUBDIR= zfs > : > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHfn2kXY6L6fI4GtQRAppgAJ9QpvBkC8V539jW5pooqk8kHPSlKQCdEBj3 RUXMZedaJ5BDZF7ZEpzaK3k= =4i0l -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080104184036.GB44815>