Date: Sat, 3 Mar 2012 09:11:29 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: "Jung-uk Kim" <jkim@freebsd.org>, freebsd-usb@freebsd.org Cc: Alexey Dokuchaev <danfe@nsu.ru>, freebsd-stable@freebsd.org Subject: Re: Resume broken in 8.3-PRERELEASE Message-ID: <201203030911.29633.hselasky@c2i.net> In-Reply-To: <201203021425.34456.jkim@FreeBSD.org> References: <20120227152238.GA2940@regency.nsu.ru> <20120302085012.GA25811@regency.nsu.ru> <201203021425.34456.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 02 March 2012 20:25:32 Jung-uk Kim wrote: > On Friday 02 March 2012 03:50 am, Alexey Dokuchaev wrote: > > On Thu, Mar 01, 2012 at 04:55:03PM -0500, Jung-uk Kim wrote: > > > It does not make a difference for me (i.e., usb suspend/resume > > > still broken) but I think I found a typo: > > > > > > --- sys/dev/usb/controller/usb_controller.c (revision 232365) > > > +++ sys/dev/usb/controller/usb_controller.c (working copy) > > > @@ -407,7 +407,7 @@ usb_bus_suspend(struct usb_proc_msg *pm) > > > > > > USB_BUS_UNLOCK(bus); > > > > > > - bus_generic_shutdown(bus->bdev); > > > + bus_generic_suspend(bus->bdev); > > > > > > usbd_enum_lock(udev); > > > > Same thing here, does not seem to improve anything. It might > > suspend, resume (with keyboard working), then die on next suspend > > completely. Or it may die on the first suspend (without suspending > > -- fans are spinning, screen is black and no response to anything > > except hard power-off), this actually happens more often. > > Try the attached patch. At least, it fixed my problem. Hi, I've committed your patch with some minor modifications. http://svn.freebsd.org/changeset/base/232448 Will you take care of the MFC to 8.3-RC + 8-stable? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203030911.29633.hselasky>