Date: Mon, 24 Feb 2014 18:30:51 +0400 From: Eygene Ryabinkin <rea@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: apache@freebsd.org, portmgr@freebsd.org Subject: Re: Patch for devel/apr1 Message-ID: <si3TtFF7heojydymL3/cz%2BBr880@W4hAcbyY3boCl2ecg4/u9JA8hSY> In-Reply-To: <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> References: <W/LXQdmArDuvEZINc6uIco1Q77Q@DMnR65URhR2fwN60Ud5mwsygncU> <rPjS0dCkOXQwLs9s6PofV/p/GT4@Edl7HbwHujl6CRBF88MhHM/peE4> <d73YgQvFILY2/L/3172O%2BSqT8sQ@Edl7HbwHujl6CRBF88MhHM/peE4> <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Mathieu, good day. Mon, Feb 24, 2014 at 02:40:34PM +0100, Mathieu Arnold wrote: > +--On 24 février 2014 04:31:40 +0400 Eygene Ryabinkin <rea@freebsd.org> > wrote: > | Sat, Feb 22, 2014 at 12:04:51PM +0400, Eygene Ryabinkin wrote: > |> Thu, Feb 20, 2014 at 11:16:40PM +0400, Eygene Ryabinkin wrote: > |> > Attached is the patch that fixes handling of WITH_/WITHOUT_ knobs > |> > (and may be something else). How to reproduce: set WITH_LDAP via > |> > make's command line and build apr1. You will end up with APR that > |> > doesn't support LDAP. Tested on port's HEAD@r343654. > |> > |> Gentlemen? Is anyone around to look at this? > | > | Involving portmgr. Gentlemen, devel/apr1 doesn't have OPTIONS_DEFINE set, > | so this breaks at least handling of WITH/WITHOUT options. Can I have > | approval for the patch? > > Hum, no, I don't see why it would be needed. What does it fix ? Building with 'make WITH_LDAP=yes', for example. It won't produce your LDAP-powered APR if you hadn't used 'make options' and selected LDAP there before. Do you familiar with http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html section 5.12.2.2? Or, alternatively, with Mk/bsd.options.mk lines 178, {{{ ALL_OPTIONS:= ${OPTIONS_DEFINE:O:u} }}} and block starting at line 260 {{{ .for opt in ${ALL_OPTIONS} .if defined(WITH_${opt}) PORT_OPTIONS+= ${opt} .endif .if defined(WITHOUT_${opt}) PORT_OPTIONS:= ${PORT_OPTIONS:N${opt}} .endif .endfor }}} Citing by $FreeBSD: head/Mk/bsd.options.mk 344393 2014-02-15 14:33:39Z antoine $. Thanks. -- Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlMLV5tfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PvT0QD/YMJZNz9JmvAyNAx70OG71OVS MLyZWXl43jf2wr5qlm4A/1chWpUYOOhoQuYB6pHE3uEjTMAU+hp3NtHCtDeAoKbp =ec9J -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?si3TtFF7heojydymL3/cz%2BBr880>