Date: Wed, 14 Oct 2015 23:23:15 +0000 From: Jonathan Looney <jlooney@juniper.net> To: Gleb Smirnoff <glebius@FreeBSD.org>, Hiren Panchasara <hiren@FreeBSD.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r289276 - in head/sys: conf kern netinet sys Message-ID: <D2445BF8.4960C%jlooney@juniper.net> In-Reply-To: <20151014113859.GS1023@FreeBSD.org> References: <201510140035.t9E0ZbXS030094@repo.freebsd.org> <20151014113859.GS1023@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/14/15, 7:38 AM, "Gleb Smirnoff" <glebius@FreeBSD.org> wrote:
>What if we write it down this way (thanks C11):
>
>struct tcpcb {
> ...
> union {
>#ifdef TCPPCAP
> struct {
> struct mbufq t_inpkts;
> struct mbufq t_outpkts;
> };
>#endif
> uint64_t _pad[6];
> }
>};
>
>So, compiler cares about pointer size, not us. And more readable, IMHO.
Hi Gleb,
Thanks! I agree. I'll include this in a cleanup patch that addresses the
comments received after the commit.
Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2445BF8.4960C%jlooney>