Date: Wed, 18 Aug 2021 11:56:35 -0400 From: Ed Maste <emaste@freebsd.org> To: Wojciech Macek <wma@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: e3500c602b13 - main - ipmi: fix negative logic in watchdog control flag Message-ID: <CAPyFy2DneuEYRLJjU15bfeDrrqnqzr-4cjHAQHeop6T0MiiXgg@mail.gmail.com> In-Reply-To: <202108180625.17I6PJmQ010784@gitrepo.freebsd.org> References: <202108180625.17I6PJmQ010784@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 18 Aug 2021 at 02:25, Wojciech Macek <wma@freebsd.org> wrote: > > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e3500c602b13f8252eb8bb779849c41d47306cee > > commit e3500c602b13f8252eb8bb779849c41d47306cee > Author: Wojciech Macek <wma@FreeBSD.org> > AuthorDate: 2021-08-18 06:21:14 +0000 > Commit: Wojciech Macek <wma@FreeBSD.org> > CommitDate: 2021-08-18 06:21:14 +0000 > > ipmi: fix negative logic in watchdog control flag Thanks! Avoiding negative logic is something that has been passed on as developer lore but isn't documented in a particularly obvious way. Yesterday I made a very small change to sysctl.9 to try to make the note about -ve logic stand out, but in the coming days I will try to take a more holistic look at style.9 to make guidance on sysctl naming and values more clear.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DneuEYRLJjU15bfeDrrqnqzr-4cjHAQHeop6T0MiiXgg>