Date: Sat, 22 Dec 2007 10:56:45 -0800 From: Marcel Moolenaar <xcllnt@mac.com> To: "Wojciech A. Koszek" <wkoszek@FreeBSD.ORG> Cc: freebsd-current@FreeBSD.ORG, emax@FreeBSD.ORG Subject: Re: [RFC, PATCH] Getting rid of direct calls to keyboard's methods via kbdsw[] array Message-ID: <75E13C5B-F31A-4EA0-BE1E-2E909364064F@mac.com> In-Reply-To: <20071222040156.GA87017@FreeBSD.czest.pl> References: <20071222040156.GA87017@FreeBSD.czest.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 21, 2007, at 8:01 PM, Wojciech A. Koszek wrote: > My proposal is to unify a way in which we call such specialized > methods, so that instead of direct array indexing used to call > specific > keyboard method: > > (*kbdsw[(kbd)->kb_index]->enable)((kbd)) > > We would use unified interface: > > kbdd_enable(kbd) > > Proposed patch is here: > > http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch > > Suggestions are welcome. I like it. It would be nice to be able to get rid of the 2nd 'd' in the kbdd_ prefix though... FYI, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?75E13C5B-F31A-4EA0-BE1E-2E909364064F>