Date: Thu, 07 Mar 2002 11:13:46 +0000 From: Mark Murray <mark@grondar.za> To: obrien@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c crypt-des.c Message-ID: <200203071113.g27BDlRV009179@grimreaper.grondar.org> In-Reply-To: <20020307025720.A63484@dragon.nuxi.com> ; from "David O'Brien" <obrien@FreeBSD.org> "Thu, 07 Mar 2002 02:57:20 PST." References: <20020307025720.A63484@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> As many people have asked in the past, please commit style(9) separately > from other commits. It is hard to see the WARNS/lint(1) changes from the > diff. In some cases that is Difficult(tm). > I would like to renew my opinion that WARNS/lint(1) fixes be reviewed on > -audit (or -hackers) before commit. (also might want to run them on your > local machine for a few days) You are changing a lot of code for reasons > of quieting lint(1), which a lot of us do not agree with. And lint(1) > quieting changes can easily become bugs as we saw with crypt-md5.c rev > 1.9. I've been running this locally since about October last year. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203071113.g27BDlRV009179>