Date: Sun, 17 Nov 2013 16:32:46 -0500 From: Eitan Adler <lists@eitanadler.com> To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= <decke@bluelife.at>, bug-followup <bug-followup@freebsd.org>, Peter Jeremy <peter@rulingia.com> Cc: vbox@freebsd.org Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Message-ID: <CAF6rxgms7y-=TYujbTQ7pRyShc2rNs-x4dvVTc90hw6KhfW2Kw@mail.gmail.com> In-Reply-To: <201311131240.rADCe13k071373@freefall.freebsd.org> References: <201311131240.rADCe13k071373@freefall.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fröhlich <decke@bluelife.at> wrote: > The following reply was made to PR ports/182468; it has been noted by GNATS. > > From: =?ISO-8859-1?Q?Bernhard_Fr=F6hlich?= <decke@bluelife.at> > To: bug-followup@FreeBSD.org, peter@rulingia.com > Cc: > Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose > Date: Wed, 13 Nov 2013 13:31:49 +0100 > > I think the idea and approach is correct but I went for a slighly more > conservative > approach if _GCC_RUNTIME was not set which is true in case base gcc is used= This can not possibly be correct as the variable begins with a "_". The initial proposed patch is also incorrect for a similar reason. _GCC_RUNTIME is not valid for use in a ports Makefile. Perhaps it would help if USE_GCC or USES=compiler exposed a variable indicating the runtime? -- Eitan Adlerhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgms7y-=TYujbTQ7pRyShc2rNs-x4dvVTc90hw6KhfW2Kw>