Date: Fri, 14 Apr 2017 13:19:49 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: Alan Somers <asomers@freebsd.org>, Ngie Cooper <ngie@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <CEC6CDCF-2EF2-4CEF-BF54-91F3021EF262@gmail.com> In-Reply-To: <20170414201431.GF20974@zxy.spb.ru> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <CAOtMX2gPHWRGiE9UA5AevZz=cTv_qksAWX0H-xRjDEHp0huCVg@mail.gmail.com> <20170414201431.GF20974@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Apr 14, 2017, at 13:14, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: > > On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper <ngie@freebsd.org> wrote: >>> Author: ngie >>> Date: Fri Apr 14 19:41:48 2017 >>> New Revision: 316938 >>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>> >>> Log: >>> savecore: fix space calculation with respect to `minfree` in check_space(..) >>> >>> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >>> representable data to INT_MAX. Check the values received from >>> strtoll(3), trimming trailing whitespace off the end to maintain >>> POLA. >>> - Use `KiB` instead of `kB` when describing free space, total space, >>> etc. I am now fully aware of `KiB` being the IEC standard for 1024 >>> bytes and `kB` being the IEC standard for 1000 bytes. >>> - Store available number of KiB in `available` so it can be more >>> easily queried and compared to ensure that there are enough KiB to >>> store the dump image on disk. >>> - Print out the reserved space on disk, per `minfree`, so end-users >>> can troubleshoot why check_space(..) is reporting that there isn't >>> enough free space. >>> >>> MFC after: 7 weeks >>> Reviewed by: Anton Rang <rang@acm.com> (earlier diff), cem (earlier diff) >>> Tested with: positive/negative cases (see review); make tinderbox >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: D10379 >> >> The free space calculation is still uselessly conservative, because it >> doesn't account for the fact that core dumps will always be either >> spare or compressed. The result is that savecore will frequently >> refuse to save corefiles even when there's plenty of space. I >> proposed removing the space check altogether in >> https://reviews.freebsd.org/D2587. However, I agreed to wait until >> after the compressed core dump feature was merged, because then mostly >> accurate space checks will be possible. AFAIK the compressed core >> dump feature still hasn't been finished. > > Is posible (in the future) to use multiple swaps (on multiple disks) > for save core dumps? Multiple swap devices is already handled by savecore(8), if one uses fstab(5) or dumpon(8). Otherwise, you must invoke savecore(8) on individual devices. As far as saving to multiple disks is concerned, I would hope that one is using a redundancy capable filesystem (zfs) or RAID-like technology (gmirror, graid, LSI Fusion’s RAID product line) to stripe and/or mirror the data across multiple disks. Thanks! -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8S7mAAoJEPWDqSZpMIYVD0YP/1KlgFSYpCIlRRlB0/oCMf60 CNmZheuJosq0Hg4ddFIUY3qtkeCGlflCBGT87TtkjUO9JjchT9qThHoxrK6WM+nS URNkAWephN9ZR2XuwkNAtXwOYMBHXvVARYD31YCpCcoCvTIKaVcW4YGfEbNgQOAR k2u64ca8VZEso6BL8CDjR9OWnn61cMKezdi8tnwkgfVbvs2pZo9DpyWpQm0syW8B IjwPe68d7MA74tgggSdAUBnso8GUjJU3QLXYw8vu11x+o9G4OHwQ0d9kO9l7AF3e ACcDF+1pRi4x9qNWpirPeRl2u+BHCbvAExK5OPFemuBFM/tFRgy4hNGTVRPfKmPM w0+zK3PpBJVjh5PS+LdKCRjE5vQvnQF88k2tJmoIlq5a7xCGpoCCLLDrUpv3U3gt vaworVe6X+4WVvOtxdWy77hPKW8LoprrxY7HADBl6SK/713wgX0UqtpOywffkc59 G55JqxKwi/5WyAFRixpFgzN1GXykVUKaROXJhJFHmOK9ET0Evxc4qJsQ3TLW+VGn 7ELzrfd+WjNAoaCtCtufWDhopZO+gzy3JzuzISpVyXlXF0MQjg89ByXqlihi6obK +jmj0mbvrKKEnX9ZQNVEEoHmsVdD0oxa0Ujh0BYH334VyfU3gWV23ogmmZDvI3JI NLtwHCAagYRtm9jSSWzw =nYn+ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CEC6CDCF-2EF2-4CEF-BF54-91F3021EF262>