Date: Tue, 4 Nov 2014 23:24:59 +0300 (MSK) From: Dmitry Morozovsky <marck@rinet.ru> To: Jung-uk Kim <jkim@freebsd.org> Cc: svn-src-head@freebsd.org, Glen Barber <gjb@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274095 - head/release Message-ID: <alpine.BSF.2.00.1411042320490.47840@woozle.rinet.ru> In-Reply-To: <5459340D.2030605@FreeBSD.org> References: <201411041724.sA4HOEGD098532@svn.freebsd.org> <alpine.BSF.2.00.1411042244180.47840@woozle.rinet.ru> <5459340D.2030605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Nov 2014, Jung-uk Kim wrote: > >> Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters, > >> in particular '-' and '.'. > > > > [snip] > > > > By the way, what are original reasons to not allow '-' and '_' in > > volume names? > > > > It looks a bit inconsistent with other file systems volume > > labels... > > AFAIK, it is an ISO9660 limitation, i.e., it must be "d-characters". > > http://wiki.osdev.org/ISO_9660#String_format > http://wiki.osdev.org/ISO_9660#The_Primary_Volume_Descriptor > > In fact, makefs(8) enforces this rule. Ah, so iso9660 has stricter rules than, say, xFAT/NTFS and even UFS... Maybe then we could distinguish file system type given to makefs(8) and apply different check/sed rules depending on it? I mean: it looks a bit unexpected (if not uncomfortable) to have label set up by outer OS accepted by geom_label (and thus created in /dev tree) but unable to duplicate it via makefs(8) and similar mechanisms... -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1411042320490.47840>