Date: Tue, 06 Jul 2004 16:46:52 +0200 From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) To: Xin LI <delphij@frontfree.net> Cc: doc@FreeBSD.org Subject: Re: About rules on style changes Message-ID: <xzpy8lx8a77.fsf@dwp.des.no> In-Reply-To: <20040706144102.GA4034@frontfree.net> (Xin LI's message of "Tue, 6 Jul 2004 22:41:02 %2B0800") References: <20040625033718.GA1691@frontfree.net> <xzpn02d9wxh.fsf@dwp.des.no> <20040706144102.GA4034@frontfree.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI <delphij@frontfree.net> writes: > Hmm... Seems that I have misunderstood the committers' guide, section > 10.3, which said: > > "Do not mix style fixes with new functionality. A style fix is any > change which does not modify the functionality of the code. Mixing the > changes obfuscates the functionality change when using cvs diff, which > can hide any new bugs." That just means you have to do it in a separate commit. We do not generally make style changes for their own sake; instead, we commit style fixes shortly before or after a functional change. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpy8lx8a77.fsf>