Date: Sat, 5 Aug 2000 17:32:12 +0200 From: Alain Thivillon <Alain.Thivillon@hsc.fr> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ccdconfig ccdconfig.c Message-ID: <20000805173212.A12185@yoko.hsc.fr> In-Reply-To: <200008050606.XAA79437@freefall.freebsd.org>; from kris@FreeBSD.org on Fri, Aug 04, 2000 at 11:06:49PM -0700 References: <200008050606.XAA79437@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway <kris@FreeBSD.org> écrivait (wrote) :
> kris 2000/08/04 23:06:49 PDT
>
> Modified files:
> sbin/ccdconfig ccdconfig.c
> Log:
> Don't call warnx() without a format string (localized error messages
> could conceivably cause a crash).
This breaks world:
mkdep -f .depend -a -I/src/5.0-CURRENT/src/sbin/ccdconfig/../../sys
-I/usr/obj/src/5.0-CURRENT/src/i386/usr/include
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c:725: unterminated string
or character constant
/src/5.0-CURRENT/src/sbin/ccdconfig/ccdconfig.c:635: possible real start
of unterminated constant
mkdep: compile failed
*** Error code 1
Stop in /src/5.0-CURRENT/src/sbin/ccdconfig.
*** Error code 1
Patch:
--- src/sbin/ccdconfig/ccdconfig.c.orig Sat Aug 5 14:05:02 2000
+++ src/sbin/ccdconfig/ccdconfig.c Sat Aug 5 17:29:50 2000
@@ -632,7 +632,7 @@
cip[i].ci_pathlen) != cip[i].ci_pathlen) {
printf("\n");
warnx("can't read component pathname");
- warnx("%s', kvm_geterr(kd));
+ warnx("%s", kvm_geterr(kd));
goto done;
}
printf((i + 1 < cs->sc_nccdisks) ? "%s " : "%s\n", path);
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000805173212.A12185>