Date: Wed, 08 Feb 2006 14:52:27 +0900 From: gnn@FreeBSD.org To: James Juran <James.Juran@baesystems.com> Cc: freebsd-net@FreeBSD.org Subject: Re: Zeroing wrong union member in in6_control() Message-ID: <m2pslyz9b8.wl%gnn@neville-neil.com> In-Reply-To: <1139330290.13750.11.camel@juran.digitalnet.com> References: <1139330290.13750.11.camel@juran.digitalnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At Tue, 07 Feb 2006 11:38:09 -0500, James Juran wrote: > > [1 <text/plain (quoted-printable)>] > In what looks like a copy&paste remnant from the preceding case, the > wrong union member is used as the first argument to bzero in > in6_control(). This doesn't cause an actual bug, but making this change > would improve code clarity and robustness to change and also avoids a > warning from a certain static analysis tool. > > I'm not a regular FreeBSD contributor, so if this patch is worthwhile > can someone please apply it? If I should send things like this to a > different mailing list in the future, please let me know. The Kame list is still the best one for this (kame <snap-users@kame.net>) but I've forwarded it for you. I'll take care of getting this into FreeBSD though. Thanks, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m2pslyz9b8.wl%gnn>