Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jun 2001 03:32:15 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Dag-Erling Smorgrav <des@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/whois Makefile whois.c
Message-ID:  <20010622033215.A302@dragon.nuxi.com>
In-Reply-To: <200106220152.f5M1qd770887@freefall.freebsd.org>; from des@FreeBSD.org on Thu, Jun 21, 2001 at 06:52:38PM -0700
References:  <200106220152.f5M1qd770887@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 21, 2001 at 06:52:38PM -0700, Dag-Erling Smorgrav wrote:
> des         2001/06/21 18:52:38 PDT
> 
>   Modified files:
>     usr.bin/whois        Makefile whois.c 
>   Log:
>   Stylify, ANSIfy, silence warnings, plug a memory leak, don't assume the
>   server is well-behaved wrt. line endings.

Uh DES, you know perfectly well that style(9) commits should be separated
from functionality commits.  Why didn't you do this as at least two
commits?

Also why did you commit something that changed

    if (x) {
        if (y) 
            z;
    }

to just

    if (x)
        if (y)
            z;

when it is perfectly allowed by style(9)?

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010622033215.A302>