Date: Mon, 17 Nov 2003 11:04:20 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: John Baldwin <jhb@FreeBSD.org> Subject: Re: cvs commit: src/sys/conf kern.post.mk kmod.mk Message-ID: <20031117105121.I4193@gamplex.bde.org> In-Reply-To: <200311160503.hAG53j2t058858@green.bikeshed.org> References: <200311160503.hAG53j2t058858@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Nov 2003, Brian F. Feldman wrote: > Bruce Evans <bde@zeta.org.au> wrote: > > On Fri, 14 Nov 2003, Robert Watson wrote: > > > > > On Fri, 14 Nov 2003, John Baldwin wrote: > > > > > > > On 14-Nov-2003 Brian Feldman wrote: > > > > > green 2003/11/14 08:04:11 PST > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/conf kern.post.mk kmod.mk > > > > > Log: > > > > > Include opt_global.h in the modules build, when building from a normal > > > > > kernel build. This makes it possible for me not to get pissed off that > > > > > ... > > > > Ugh. > > > > > > WITNESS doesn't matter as all calls to it are done in the actual locking > > > > code itself which does not lives in modules. Modules always call the > > > > locking functions and don't inline locking operations. > > > > WITNESS actually has non-broken support for modules. Modules cannot depend > > on options, since they must work for all kernels. > > > > Here is a fix to unbreak the rdtsc() call similarly. > > I dunno, Bruce; I don't really agree with you there. Modules are installed, > as they are built in the src/sys/arch/compile/KERNEL directories, into the > same directories as the kernel. That is another bug :-). It mainly wastes space and time, and steals cycles from development of portable modules. > This implies they're matched with the > kernel. I think depending on options in those modules is totally, perfectly > fine. Agreed, this is required the support the bug. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031117105121.I4193>