Date: Thu, 16 Jun 2011 20:47:43 -0400 From: Sahil Tandon <sahil@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Wen Heping <wen@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile Message-ID: <20110617004742.GD19139@magic.hamla.org> In-Reply-To: <20110616164733.GA40181@FreeBSD.org> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: > On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: > > wen 2011-06-16 08:42:28 UTC > > > > Modified files: > > sysutils/tmux Makefile > > Log: > > - Fix build when CFLAGS is set in /etc/make.conf > > Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of > introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is > bogus in the first place: -I is preprocessor flag) should be enough (no > MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in this > case as well). I am missing something obvious here? Because of the way upstream Makefile handles CPPFLAGS, it is not so straightforward. This was discussed on freebsd-ports: http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.html http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.html -- Sahil Tandon <sahil@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110617004742.GD19139>