Date: Tue, 19 Jul 2011 11:17:02 -0700 From: Artem Belevich <art@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: markmc@dataabstractsolutions.com, "freebsd-stable@freebsd.org Stable" <freebsd-stable@freebsd.org> Subject: Re: disable 64-bit dma for one PCI slot only? Message-ID: <CAFqOu6gqYKdOv6ojpTeVX5MzgVnLibvf=XjGsC1j6w5kFnvN=w@mail.gmail.com> In-Reply-To: <201107190931.36492.jhb@freebsd.org> References: <4E20BA23.13717.66C6F57@markmcconnell.iinet.com> <201107181714.07827.jhb@freebsd.org> <4F739848-E3CE-4E2C-A91E-90F33410E7AC@samsco.org> <201107190931.36492.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Tue, Jul 19, 2011 at 6:31 AM, John Baldwin <jhb@freebsd.org> wrote: > The only reason it might be nice to stick with two fields is due to the line > length (though the first line is over 80 cols even in the current format). Here > are two possible suggestions: > > old: > > hostb0@pci0:0:0:0: class=0x060000 card=0x20108086 chip=0x01008086 rev=0x09 hdr=0x00 > pcib1@pci0:0:1:0: class=0x060400 card=0x20108086 chip=0x01018086 rev=0x09 hdr=0x01 > pcib2@pci0:0:1:1: class=0x060400 card=0x20108086 chip=0x01058086 rev=0x09 hdr=0x01 > none0@pci0:0:22:0: class=0x078000 card=0x47428086 chip=0x1c3a8086 rev=0x04 hdr=0x00 > em0@pci0:0:25:0: class=0x020000 card=0x00008086 chip=0x15038086 rev=0x04 hdr=0x00 > ... > > A) > > hostb0@pci0:0:0:0: class=0x060000 vendor=0x8086 device=0x0100 subvendor=0x8086 subdevice=0x2010 rev=0x09 hdr=0x00 > pcib1@pci0:0:1:0: class=0x060400 vendor=0x8086 device=0x0101 subvendor=0x8086 subdevice=0x2010 rev=0x09 hdr=0x01 > pcib2@pci0:0:1:1: class=0x060400 vendor=0x8086 device=0x0105 subvendor=0x8086 subdevice=0x2010 rev=0x09 hdr=0x01 > none0@pci0:0:22:0: class=0x078000 vendor=0x8086 device=0x1c3a subvendor=0x8086 subdevice=0x4742 rev=0x04 hdr=0x00 > em0@pci0:0:25:0: class=0x020000 vendor=0x8086 device=0x1503 subvendor=0x8086 subdevice=0x0000 rev=0x04 hdr=0x00 > ... > > B) > > hostb0@pci0:0:0:0: class=0x060000 devid=0x8086:0100 subid=0x8086:2010 rev=0x09 hdr=0x00 > pcib1@pci0:0:1:0: class=0x060400 devid=0x8086:0101 subid=0x8086:2010 rev=0x09 hdr=0x01 > pcib2@pci0:0:1:1: class=0x060400 devid=0x8086:0105 subid=0x8086:2010 rev=0x09 hdr=0x01 > none0@pci0:0:22:0: class=0x078000 devid=0x8086:1c3a subid=0x8086:4742 rev=0x04 hdr=0x00 > em0@pci0:0:25:0: class=0x020000 devid=0x8086:1503 subid=0x8086:0000 rev=0x04 hdr=0x00 > ... > > I went with vendor word first for both A) and B) as in my experience that is > the more common ordering in driver tables, etc. Do we need to print (class|devid|device|subvendor|etc.)= on every line? IMHO they belong to a header line. Something like this: Driver Handle Class Vnd:Dev Sub Vnd:Dev Rev Hdr ------------------------------------------------------------------ hostb0 pci0:0:0:0 0x060000 0x8086:0100 0x8086:2010 0x09 0x00 pcib1 pci0:0:1:0 0x060400 0x8086:0101 0x8086:2010 0x09 0x01 pcib2 pci0:0:1:1 0x060400 0x8086:0105 0x8086:2010 0x09 0x01 none0 pci0:0:22:0 0x078000 0x8086:1c3a 0x8086:4742 0x04 0x00 em0 pci0:0:25:0 0x020000 0x8086:1503 0x8086:0000 0x04 0x00 --Artemhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFqOu6gqYKdOv6ojpTeVX5MzgVnLibvf=XjGsC1j6w5kFnvN=w>