Date: Sat, 1 Aug 2009 01:37:16 +0200 From: Ed Schouten <ed@80386.nl> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Attilio Rao <attilio@freebsd.org>, Peter Holm <pho@freebsd.org>, freebsd-current@freebsd.org Subject: Re: [PATCH] Newbus locking Message-ID: <20090731233716.GT1292@hoeg.nl> In-Reply-To: <200907311818.08481.hselasky@c2i.net> References: <3bbf2fe10907310759o3be1f565t4122fcd66c4531f4@mail.gmail.com> <200907311818.08481.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] * Hans Petter Selasky <hselasky@c2i.net> wrote: > I was hoping that the Giant requirement for newbus would go away, but all that > has been done is to replace Giant with an sx-lock protecting all access and > calls into any device_xxx() method. This is a step backwards. Gradually decomposing Giant should always be considered a step forward. For example, I am sure people will have dozens of comments on how I could have improved locking inside the TTY layer, but it's still better than what we had. <nitpick> Attilio, I'm too stupid to understand Newbus, but I spotted a small typo in acpi_battery.c: Tollerate -> Tolerate. There's also a small whitespace regression in the first chunk of the same file. </nitpick> -- Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkpzgCwACgkQ52SDGA2eCwXhFQCfQrQZvCwLZj0rD+ZqsRB2cfn7 8/kAn1aZJMiCZkzympu3qApCNuf4koH7 =Whsf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090731233716.GT1292>