Date: Tue, 17 Jan 2017 16:52:25 -0700 From: Ian Lepore <ian@freebsd.org> To: cem@freebsd.org, Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg Message-ID: <1484697145.86335.183.camel@freebsd.org> In-Reply-To: <CAG6CVpXTVucnJUXzx%2B7VPPHkw-AptwSdNCjnz2QsTrgewGqKVA@mail.gmail.com> References: <201701161746.v0GHkcPX071529@repo.freebsd.org> <20170117065231.GW2611@FreeBSD.org> <CAH7qZftckckygNG3HRqikiaGds6FsOedUR7AWKGi-PJg96FQjA@mail.gmail.com> <CAH7qZftsYAoBj7gFpOMHgT9a12N1yshAGY%2BkAEkpbTks7LL29Q@mail.gmail.com> <20170117212713.GZ2611@FreeBSD.org> <CAH7qZfuu7SWG7Ff7k1BU6ChwwA4SqC%2BG%2BcTHjtjEr%2BAS_Q5p0g@mail.gmail.com> <CAG6CVpXTVucnJUXzx%2B7VPPHkw-AptwSdNCjnz2QsTrgewGqKVA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I actually don't agree that it's all good, but I also don't have the time to prove it's not (or prove myself wrong, which could certainly be the case). -- Ian On Tue, 2017-01-17 at 15:21 -0800, Conrad Meyer wrote: > Ian's potential objection has been met by Ben Kaduk and Eric van > Gyzen's responses. It seems like an enum is just fine. And I agree > with Gleb that it is preferable. > > Conrad > > On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev <sobomax@freebsd.org> > wrote: > > > > Well as other pointed out there are some concerns with using enums > > from C++ > > and ABI prospective. So it looks to me that there is no general > > consensus on > > that direction. > > > > -Max > > > > On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff <glebius@freebsd.org > > > wrote: > > > > > > > > > On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: > > > M> That being said, is there any other socket option value in > > > there > > > M> implemented as enum? I don't see anything obvious, so that I > > > am curious > > > if > > > M> it would stick out as an odd one in there. What do you think? > > > > > > Simply because 30 years ago the language didn't allow that, and > > > later > > > additions mimiced the older sockopts. We need to break this loop > > > :) > > > > > > -- > > > Totus tuus, Glebius. > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1484697145.86335.183.camel>