Date: Fri, 07 Jan 2005 14:26:40 -0500 From: Stephan Uphoff <ups@tree.com> To: Xin LI <delphij@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 apic_vector.s mp_machdep.c src/sys/i386/include apicvar.h smp.h Message-ID: <1105126000.33592.47.camel@palm.tree.com> In-Reply-To: <200501060202.j0622aSw064745@repoman.freebsd.org> References: <200501060202.j0622aSw064745@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks - especially for all the testing! Stephan On Wed, 2005-01-05 at 21:02, Xin LI wrote: > delphij 2005-01-06 02:02:36 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > sys/i386/i386 apic_vector.s mp_machdep.c > sys/i386/include apicvar.h smp.h > Log: > MFC IPI panic fix done by Stephan Uphoff: > sys/i386/i386/apic_vector.s 1.101 -> 1.102 > sys/i386/i386/mp_machdep.c 1.241 -> 1.243 > sys/i386/include/apicvar.h 1.8 -> 1.9 > sys/i386/include/smp.h 1.78 -> 1.79 > > To quote the original commit message: > Avoid more than two pending IPI interrupt vectors per local APIC > as this may cause deadlocks. > > This should fix kern/72123. > > Discussed with: jhb > Tested by: Nik Azim Azam, Andy Farkas, Flack Man, Aykut KARA > Izzet BESKARDES, Jens Binnewies, Karl Keusgen > Approved by: sam (mentor) > > This commit is a combination of Stephan's original one and John's style > fix on mp_machdep.c. I have tested the patch on various SMP boxes running > RELENG_5_3 (4*P3 Xeon, 2*P4 w/HTT, 2*P4 Xeon configurations) under heavy > load for a couple of weeks, so commit on behalf of Stephan when he is > on vacation. > > RELENG_5_3 candidate after settle time. > > Discussed with: ups > Reviewed by: jhb > > Revision Changes Path > 1.101.2.1 +4 -52 src/sys/i386/i386/apic_vector.s > 1.235.2.4 +65 -37 src/sys/i386/i386/mp_machdep.c > 1.8.2.1 +42 -9 src/sys/i386/include/apicvar.h > 1.78.2.1 +2 -5 src/sys/i386/include/smp.h > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1105126000.33592.47.camel>