Date: Thu, 05 Jul 2001 21:54:10 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Mike Smith <msmith@FreeBSD.org> Cc: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h Message-ID: <7638.994362850@critter> In-Reply-To: Your message of "Tue, 03 Jul 2001 13:51:18 PDT." <200107032051.f63KpIm01502@mass.dis.org>
index | next in thread | previous in thread | raw e-mail
>> > > sys/sys bio.h
>> > > Log:
>> > > Define BIO_CMD{1,2}, available for local hacks, similar to the already
>> > > existing BIO_FLAG{1,2}. To be used in the fdc(4) driver soon.
As the legal custodian of bio.h, I would like to express my
displeasure with this commit as well.
I have looked at what the FD driver does myself when I tried to
implement the bio structure.
I think the FD driver has a rather Oedipudian relationship with
struct buf/bio.
If you isist that the FD driver continue this praxis, please move
these definitions to the driver source code so it doesn't pollute
future code or minds.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7638.994362850>