Date: Fri, 14 Jun 2002 04:48:05 +0300 (EEST) From: Maxim Sobolev <sobomax@FreeBSD.org> To: jmallett@FreeBSD.org (Juli Mallett) Cc: sobomax@FreeBSD.org (Maxim Sobolev), petef@absolutbsd.org (Pete Fritchman), trevor@jpj.net (Trevor Johnson), portmgr@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <200206140148.g5E1m5A10249@vega.vega.com> In-Reply-To: <20020613183556.A76276@FreeBSD.ORG> from "Juli Mallett" at Jun 13, 2002 06:35:56 PM
next in thread | previous in thread | raw e-mail | index | archive | help
> > * Maxim Sobolev <sobomax@FreeBSD.org> escriurères > > > > > > * Pete Fritchman <petef@absolutbsd.org> escriurères > > > > The addition of sed -i came when perl was removed. > > > > > > Wasn't it before? I forget now, it was ages ago in my mind. > > > > > > Anyway, it's on my list of things to MFC, but it was controversial when it was > > > on the tip of my mind, and I had trivial stuff I was having trouble getting to > > > the RELENG_4 branch during the freeze, so I decided I'd wait for the free for > > > all. I'd like to see ports move over to using it once it's been MFC'd for a > > > while... > > > > It was actually fortunate that it didn't go into 4.6 because I've just > > found and hopefully fixed one serious -i misbehaviour and one potential > > problem in sed(1). See commit logs for details. > > I went to great lengths to get review of my -i patches, including taking a > good deal of abuse for parts of them. I would have loved to have seen you > try to get some review too, since you say "hopefully fixed" and therefore > don't sound too sure of it. Well, I don't have a time for full-fledged review because the first problem with handling of multiple files would prevent me and others from doing REINPLACE_CMD sweep. I've tested it extensively here and don't plan to do MFC earlier than in 1-2 months, so that there will be plenty of time for testing. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206140148.g5E1m5A10249>