Date: Sat, 07 Aug 2010 23:51:39 +0400 From: Anonymous <swell.k@gmail.com> To: Christian Weisgerber <naddy@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/connect4 Makefile pkg-descr pkg-plist ports/games/connect4/files patch-aa patch-ab patch-ac Message-ID: <86k4o2b3qs.fsf@gmail.com> In-Reply-To: <201008071924.o77JObWZ043660@repoman.freebsd.org> (Christian Weisgerber's message of "Sat, 7 Aug 2010 19:24:37 %2B0000 (UTC)") References: <201008071924.o77JObWZ043660@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Christian Weisgerber <naddy@FreeBSD.org> writes:
> naddy 2010-08-07 19:24:37 UTC
>
> FreeBSD ports repository
>
> Modified files:
> games/connect4 Makefile pkg-descr pkg-plist
> games/connect4/files patch-aa patch-ab patch-ac
> Log:
> Remove a bogus handrolled setproctitle() from ye olden days, fixes
> crashes on 64-bit archs. Add missing #includes.
>
> Move high-score file to /var/games.
>
> Better pkg-descr.
>
> PR: 149406
>
> Revision Changes Path
> 1.15 +8 -4 ports/games/connect4/Makefile
Why not pass $(SCOREFILE) to vendor makefile from port's one?
MAKE_ENV += SCOREFILE=${SCOREFILE}
It'll save one from keeping in mind *two* places where the value is
hardcoded.
Otherwise, I'm not the maintainer to complain about overriding
owner/group in INSTALL_(PROGRAM|DATA) rather than setting defaults.
> 1.3 +17 -30 ports/games/connect4/files/patch-aa
> 1.2 +83 -49 ports/games/connect4/files/patch-ab
> 1.2 +10 -23 ports/games/connect4/files/patch-ac
While converting diffs to unified formats you could have given patch
files more descriptive names, too. The effect would be mostly same for
`cvs annotate'.
> 1.3 +5 -7 ports/games/connect4/pkg-descr
> 1.5 +3 -2 ports/games/connect4/pkg-plist
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k4o2b3qs.fsf>