Date: Fri, 9 Aug 2013 12:17:01 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Jan Beich <jbeich@tormail.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r253862 - head/sys/boot/ficl Message-ID: <2E62CB17-8E7E-44C0-ADD1-F58E6EDECCBE@xcllnt.net> In-Reply-To: <1V6Cmb-000M0k-0l@internal.tormail.org> References: <201308011806.r71I6xpd088690@svn.freebsd.org> <1V65V2-0001RI-Fu@internal.tormail.org> <953FDB6A-11EF-46D3-85D8-634952AF9309@xcllnt.net> <1V6Cmb-000M0k-0l@internal.tormail.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 4, 2013, at 9:52 PM, Jan Beich <jbeich@tormail.org> wrote: > >> >> It's probably not going to work on any other FS. The >> alternative is to just not support freaddir due to lack >> of runtime support. > > What's the issue with my version in bin/172542 ? It doesn't > use d_reclen but relies on a side-effect of readdir() call. It leaks memory and doesn't handle the use of freaddir with different fds interspersed. It's flawed in a different way. FYI, -- Marcel Moolenaar marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2E62CB17-8E7E-44C0-ADD1-F58E6EDECCBE>