Date: Thu, 10 Nov 2016 08:05:51 -0800 From: Adrian Chadd <adrian.chadd@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: Lewis Donzis <lew@perftech.com>, freebsd-current <freebsd-current@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: SM bus ioctls incorrect in FreeBSD 11 Message-ID: <CAJ-Vmo=c=_D4fb=-Yq_0EnyptAgWbF4m5CBxvTegG3RvQacbNA@mail.gmail.com> In-Reply-To: <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org> References: <06929AC5-D350-4236-A813-56C862B58174@perftech.com> <fe780e23-f014-1c84-b702-12727cd68ef0@FreeBSD.org> <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com> <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+10 on option 2. Hate to say it, but I'd rather this little corner of freebsd be "right" before it gets more heavily used. -a On 10 November 2016 at 03:21, Andriy Gapon <avg@freebsd.org> wrote: > On 14/10/2016 18:51, Lewis Donzis wrote: >> Our opinion doesn=E2=80=99t count for much, but I like 2 or 4. Option 1= would >> essentially obviate the entire purpose of changing the structure. Optio= n 2 >> basically finishes the job and makes it work properly. Option 3 is, as = you >> say, unappealing. I have no problem with Option 4, obviously we can cha= nge >> our code back to the old way, but assuming there was a good reason for t= his >> change in the first place, Option 2 seems more logical. >> >> But whatever y=E2=80=99all decide is fine with us, we=E2=80=99ll just ch= ange code to match at >> the appropriate time. > > Anyone interested in the issue, could you please take a look at this revi= ew? > https://reviews.freebsd.org/D8430 > > Thank you. > > -- > Andriy Gapon > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=c=_D4fb=-Yq_0EnyptAgWbF4m5CBxvTegG3RvQacbNA>