Date: Sun, 2 Sep 2012 17:59:28 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Alan Cox <alc@rice.edu> Cc: mips@freebsd.org Subject: Re: gxemul_disk.c Message-ID: <CACVs6=_FMsD3eHdo%2Bk7mBPfL9AzoSAM2od%2BUOX1qspH1x%2BpX%2Bg@mail.gmail.com> In-Reply-To: <5043E6AC.8040101@rice.edu> References: <5043E6AC.8040101@rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Indeed, you seem to be quite right. Feel free to commit the fix.
Thanks,
Juli.
On Sun, Sep 2, 2012 at 4:07 PM, Alan Cox <alc@rice.edu> wrote:
> There appears to be a simple typo in gxemul_disk.c that prevents changes
> from being written back to the emulated disk:
>
> Index: dev/gxemul/disk/gxemul_disk.c
> ===================================================================
> --- dev/gxemul/disk/gxemul_disk.c (revision 240002)
> +++ dev/gxemul/disk/gxemul_disk.c (working copy)
> @@ -286,7 +286,7 @@ gxemul_disk_write(unsigned diskid, const void *buf
> dst = GXEMUL_DISK_DEV_FUNCTION(GXEMUL_DISK_DEV_BLOCK);
> memcpy((void *)(uintptr_t)dst, buf, GXEMUL_DISK_DEV_BLOCKSIZE);
>
> - GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_READ);
> + GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_WRITE);
> switch (GXEMUL_DISK_DEV_READ(GXEMUL_DISK_DEV_STATUS)) {
> case GXEMUL_DISK_DEV_STATUS_FAILURE:
> return (EIO);
>
> Or am I missing something?
>
> Regards,
> Alan
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=_FMsD3eHdo%2Bk7mBPfL9AzoSAM2od%2BUOX1qspH1x%2BpX%2Bg>