Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Sep 2012 12:27:10 -0700
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@freebsd.org, Kevin Lo <kevlo@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r240850 - head/lib/libstand
Message-ID:  <CAGH67wQf5whjgQmXD3Ln_-r=WsLMYrBQUBj_G-HoGf1a5F_4cg@mail.gmail.com>
In-Reply-To: <20120923105220.GL37286@deviant.kiev.zoral.com.ua>
References:  <201209230838.q8N8c6Tu056083@svn.freebsd.org> <20120923105220.GL37286@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:
> On Sun, Sep 23, 2012 at 08:38:06AM +0000, Kevin Lo wrote:
>> Author: kevlo
>> Date: Sun Sep 23 08:38:06 2012
>> New Revision: 240850
>> URL: http://svn.freebsd.org/changeset/base/240850
>>
>> Log:
>>   Avoid NULL dereference
>>
>> Modified:
>>   head/lib/libstand/nfs.c

...

> I do not see how this change is useful. libstand' Free() function handles
> NULL parameter fine, as well as all other free(3) implementations I am
> aware of.

    +1. free(3) should silently ignore NULL parameters passed into it.
Thanks,
Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQf5whjgQmXD3Ln_-r=WsLMYrBQUBj_G-HoGf1a5F_4cg>