Date: Tue, 04 May 2021 15:54:31 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 255579] devel/py-pip: Fails to build with DOCS enabled: SyntaxError: future feature annotations is not defined Message-ID: <bug-255579-21822-TPdlkaPPKG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-255579-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-255579-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255579 --- Comment #2 from John Hein <jcfyecrayz@liamekaens.com> --- (In reply to Kubilay Kocak from comment #1) Yes, I did see that python_requires=3D'>=3D2.7,!=3D3.0.*,!=3D3.1.*,!=3D3.2.*,!=3D3.3.*,!=3D3.4.= *' in setup.py and considered that. My [brief] thinking was: We already deviate from the upstream 'requires' spec due to overriding free= bsd project concerns, namely: we don't support python2.7 or python3.5 anymore. = So that's why the port has USES=3Dpython:3.6+ - if we strictly adhered to a regurgitation of the upstream requirement spec, it should have USES=3Dpython:2.7,3.5+. But, of course, this case is different since it is= not _freebsd_ that chose not to support the older versions, but upstream (altho= ugh possibly unintentionally) when they added the new requirement without updat= ing 'requires'. The freebsd port chooses to optionally build the documentation (if DOCS is = on). Upstream may consider 'build_sphinx' a second class citizen when considering its 'requires'. If so, then it seems it would be okay to set USES=3Dpython= :3.7+. If not, then I agree it is just an outright upstream bug. I suspect you're right, and they DON'T consider build_sphinx a second class citizen, so the full-on 'bug' moniker would be correct. That said, until they fix upstream, our ports tree is [slightly] broken (especially since DOCS is on by default). So that's the main reason I advocated setting USES=3Dpython:3.7+ for now - that can be a reasonable tem= porary workaround (at least when we build with DOCS). The breakage is pretty minor, however, since the default python version is = now > 3.6. Because of that, very few people will hit this bug. If you don't t= hink it's worth our time to commit anything to address the breakage, that's okay with me. I can just close this with a "won't fix" resolution. For now, I'= ll just let this sit and wait a while to hear from upstream. For reference, here is the upstream issue report (yes, that was from me): https://github.com/pypa/pip/issues/9941 No bites yet. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255579-21822-TPdlkaPPKG>