Date: Thu, 30 Aug 2001 17:36:20 +0100 From: Brian Somers <brian@Awfulhak.org> To: Dima Dorfman <dd@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/usr.sbin/pw grupd.c Message-ID: <200108301636.f7UGaKf07929@hak.lan.Awfulhak.org> In-Reply-To: Message from Dima Dorfman <dd@FreeBSD.org> of "Wed, 29 Aug 2001 23:32:17 PDT." <200108300632.f7U6WHB31855@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> dd 2001/08/29 23:32:17 PDT
>
> Modified files:
> usr.sbin/pw grupd.c
> Log:
> Unbreak group operations by reverting previous delta which removed the
> assignment of `l' in `gr_update' to the return value of snprintf. It
> claimed to have fixed the case where snprintf returned -1--in fact, it
> broke the entire routine. Not setting `l' here causes fileupdate() to
> invariably fail with EINVAL because it does its own check to assert
> that the parameter isn't -1.
>
> Revision Changes Path
> 1.10 +2 -2 src/usr.sbin/pw/grupd.c
Pointy hat to: brian
That was a bad mistake. I (wrongly) thought that the return value
wasn't being used. Thanks for fixing this.
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108301636.f7UGaKf07929>