Date: Tue, 6 Jul 2004 15:15:14 +0000 (UTC) From: Dag-Erling Smorgrav <des@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/contrib/isc-dhcp/client dhclient.c src/contrib/isc-dhcp/common dispatch.c src/contrib/isc-dhcp/includes dhcpd.h src/contrib/isc-dhcp/omapip dispatch.c mrtrace.c Message-ID: <200407061515.i66FFEMx028139@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
des 2004-07-06 15:15:14 UTC
FreeBSD src repository
Modified files:
contrib/isc-dhcp/client dhclient.c
contrib/isc-dhcp/common dispatch.c
contrib/isc-dhcp/includes dhcpd.h
contrib/isc-dhcp/omapip dispatch.c mrtrace.c
Log:
Fix a number of incorrect assumptions regarding the size of time_t.
The code has its own TIME type, which is actually defined to time_t,
but it still used u_int32_t in some places.
In addition, dhclient not only had two separate global cur_time
variables, one of which was defined as u_int32_t and the other as
TIME, but cur_time was sometimes shadowed by local variables, leading
to widespread confusion as to which of these variable was being
referenced.
There is a lesson in here somewhere: a decent compiler with warnings
enabled should have caught all of this long before it became a
problem.
This patch has been submitted to the vendor, but it will likely be
some time before they release a version that includes it.
Approved by: mbr
Revision Changes Path
1.38 +1 -1 src/contrib/isc-dhcp/client/dhclient.c
1.6 +1 -2 src/contrib/isc-dhcp/common/dispatch.c
1.10 +2 -2 src/contrib/isc-dhcp/includes/dhcpd.h
1.2 +22 -29 src/contrib/isc-dhcp/omapip/dispatch.c
1.2 +22 -29 src/contrib/isc-dhcp/omapip/mrtrace.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407061515.i66FFEMx028139>