Date: Wed, 29 Jul 2015 19:15:44 +0200 From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@cochard.me>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285051 - head/sys/netinet Message-ID: <CAPBZQG2s=By2q4t4yssAx87Fboksko3-L9cmGsW1TJAZZdn3hw@mail.gmail.com> In-Reply-To: <B341CBB9-DF4A-4455-B086-9446BA059198@neville-neil.com> References: <201507021810.t62IAgCc003272@repo.freebsd.org> <20150728124220.GW72729@FreeBSD.org> <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com> <20150729150544.GM97401@FreeBSD.org> <B341CBB9-DF4A-4455-B086-9446BA059198@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 29, 2015 at 6:48 PM, George Neville-Neil <gnn@neville-neil.com>
wrote:
>
>
> On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote:
>
> Ermal,
>>
>> On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Lu=C3=A7i wrote:
>> E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt)
>> E> > E> */
>> E> > E> if (!srcrt && ia =3D=3D NULL) {
>> E> > E> icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0, 0=
);
>> E> > E> + RO_RTFREE(&ro);
>> E> > E> return;
>> E> > E> }
>> E> >
>> E> > Here the ifa reference is leaked upon return.
>> E> >
>> E> >
>> E> Gleb,
>> E>
>> E> the improvement on the ifa_ref not needed is something to look at but
>> the
>> E> ifa_ref here is not lost since ia =3D=3D NULL, no?
>> E> Maybe i am missing something else.
>>
>> Sure you are right. Mea culpa.
>>
>> E> Also can we put this on a review?
>>
>> It is possible. Let's just wait for Olivier to return and ask him to
>> do a benchmark :)
>>
>>
> Olivier isnt' the only one that can do a benchmark. I can chuck this up
> in the
> Sentex lab, that's what it's for. Give me a brief outline and I'll code
> something
> up in Conductor.
>
The outline is simple.
Just forwarding performance in terms of PPS for normal forwarding with the
patch suggested from Gleb builtin.
pmcstat data would be useful as well during this bench :)
>
> Best,
> George
>
--=20
Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG2s=By2q4t4yssAx87Fboksko3-L9cmGsW1TJAZZdn3hw>