Date: Fri, 21 Sep 2007 13:53:41 +0200 From: Henrik Brix Andersen <henrik@brixandersen.dk> To: Kevin Lo <kevlo@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/getfacl getfacl.c Message-ID: <20070921115341.GD1501@tirith.brixandersen.dk> In-Reply-To: <1190351847.6206.5.camel@monet> References: <200709190204.l8J24llM050769@repoman.freebsd.org> <20070919090501.GA2479@tirith.brixandersen.dk> <1190351847.6206.5.camel@monet>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Sep 21, 2007 at 01:17:27PM +0800, Kevin Lo wrote:
> Henrik Brix Andersen wrote:
> > On Wed, Sep 19, 2007 at 02:04:47AM +0000, Kevin Lo wrote:
> > > kevlo 2007-09-19 02:04:47 UTC
> > >
> > > FreeBSD src repository
> > >
> > > Modified files:
> > > bin/getfacl getfacl.c
> > > Log:
> > > Use owner name and owning group name instead of uid and gid
> > > for displaying the three-line comment header by default.
> > >
> > > Reviewed by: kientzle
> > > Approved by: re (bmah)
> >
> > Isn't this a POLA violation? At least I think it should be mentioned
> > in UPDATING as people might (I know I do) have scripts, that actually
> > parse the uid/gid fields in the header.
>
> How about adding a "-n" option to display user and group IDs
> numerically? thoughts?
That may be overkill... As far as I am concerned, a simple entry in
UPDATING is sufficient. Here's my suggested patch:
--- /usr/src/UPDATING 2007-07-09 11:11:19.000000000 +0200
+++ UPDATING 2007-09-21 13:50:33.000000000 +0200
@@ -21,6 +21,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 7.
developers choose to disable these features on build machines
to maximize performance.
+20070921:
+ The getfacl(1) utility now prints owning user and group name
+ instead of owning uid and gid in the three line comment
+ header. This is the same behavior as getfacl(1) on Solaris and
+ Linux.
+
20070704:
The new IPsec code is now compiled in using the IPSEC option. The
IPSEC option now requires "device crypto" be defined in your kernel
Regards,
Brix
--
Henrik Brix Andersen <henrik@brixandersen.dk>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
Comment: GnuPG signed
iD8DBQFG87DFv+Q4flTiePgRAiO7AKC4tTMjgSg8n/3IIqDQjnkb+b7gbwCgmWPa
py958hJz6OFE0xHuKaUHm7Y=
=+28e
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070921115341.GD1501>