Date: Fri, 25 Mar 2011 11:13:39 -0700 (PDT) From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD Message-ID: <758552.89055.qm@web113514.mail.gq1.yahoo.com> In-Reply-To: <20110325165314.GO78089@deviant.kiev.zoral.com.ua>
index | next in thread | previous in thread | raw e-mail
Hello; --- On Fri, 3/25/11, Kostik Belousov <kostikbel@gmail.com> wrote: ... > > Fixes NetBSD PR #44661 > Can you extract the test referenced in the commit message > ? Here is the NetBSD link: http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/fs/vfs/t_vnops.c.diff?r1=1.21&r2=1.22 but I have no idea if it will apply to our testing framework. > > I think that s/EROFS/EINVAL/ change could and should be > committed first, and then the (potential) fix for the > vnode leakage as a separate commit. > It takes some time to get patches committed, so I usually prefer to submit bigger patches, if I can, in order to save reviewer's time. FWIW, I prefer so much bugzilla since permits better patch handling and obsoleting the diffs that have been applied already.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?758552.89055.qm>