Date: Tue, 20 Mar 2018 08:54:39 -0700 From: John Baldwin <jhb@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331057 - head/sys/compat/linux Message-ID: <2422935.GGHXCazita@ralph.baldwin.cx> In-Reply-To: <CAPyFy2B4Fm9dXJRQX2kiyGeU9AQxNFoS50UEs1CSUWZg8-9kCw@mail.gmail.com> References: <201803161451.w2GEpl3T053141@repo.freebsd.org> <1806390.PUHUxB7aSs@ralph.baldwin.cx> <CAPyFy2B4Fm9dXJRQX2kiyGeU9AQxNFoS50UEs1CSUWZg8-9kCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, March 19, 2018 05:32:22 PM Ed Maste wrote: > On 16 March 2018 at 17:08, John Baldwin <jhb@freebsd.org> wrote: > > On Friday, March 16, 2018 02:51:47 PM Ed Maste wrote: > >> Author: emaste > >> Date: Fri Mar 16 14:51:47 2018 > >> New Revision: 331057 > >> URL: https://svnweb.freebsd.org/changeset/base/331057 > >> > >> Log: > >> linux_errno.c: add newer errno values > > > > Could you move the table to a header perhaps so it can also be shared > > with lib/libsysdecode/errno.c (which has another copy of this table)? > > I found that copy shortly after I made this change (and then updated > it to match). We could just add linux_errno.c to libsysdecode though? Probably. I'd like to avoid exporting the symbol if possible. Currently that is done by marking it static in errno.c, but if I compile in linux_errno.c as-is it would be a global symbol (and would need to be exported to errno.c at least). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2422935.GGHXCazita>