Date: Fri, 14 Aug 2009 04:53:24 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Julian Elischer <julian@elischer.org> Cc: freebsd-current@FreeBSD.org Subject: Re: panic in ipfw with recent current Message-ID: <20090814005324.GA1552@hades.panopticon> In-Reply-To: <4A84A901.4010109@elischer.org> References: <20090801022523.GA93222@hades.panopticon> <4A84A901.4010109@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Julian Elischer (julian@elischer.org) wrote:
> found the fix I think..
>
> in line 2061 of ip_fw2.c in the crhold()
> the argument should be pcb->inp_cred, not inp->cred
>
> 2059 if (pcb != NULL) {
> 2060 *uc = crhold(inp->inp_cred); <--s/inp/pcb/
> 2061 *ugid_lookupp = 1;
> 2062 }
Confirmed, this fixes the problem. Filtering by gid works and no
panics. Thanks a lot!
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090814005324.GA1552>