Date: Thu, 11 Sep 2025 10:57:26 -0600 From: Warner Losh <imp@bsdimp.com> To: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@freebsd.org> Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d20c82507278 - main - Revert "libc: Remove readdir_r(3)" Message-ID: <CANCZdfqqQ-vGTXYQ==J_LD6a2%2Be1GwcGmkJJ5n=4zbyS7Cd9dg@mail.gmail.com> In-Reply-To: <CA%2Bq%2BTcrYcX5eDnKVb2sgvwofUJ55SF6Q0nuEH6L2M4uchSsWhQ@mail.gmail.com> References: <202509111512.58BFCV87088340@gitrepo.freebsd.org> <CA%2Bq%2BTcrYcX5eDnKVb2sgvwofUJ55SF6Q0nuEH6L2M4uchSsWhQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Sep 11, 2025 at 10:27 AM Olivier Cochard-Labbé <olivier@freebsd.org> wrote: > > On Thu, Sep 11, 2025 at 8:12 AM Dag-Erling Smørgrav <des@freebsd.org> > wrote: > >> The branch main has been updated by des: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=d20c82507278e003f391c3fb04f4e49afd1537ab >> >> commit d20c82507278e003f391c3fb04f4e49afd1537ab >> Author: Dag-Erling Smørgrav <des@FreeBSD.org> >> AuthorDate: 2025-09-11 15:12:22 +0000 >> Commit: Dag-Erling Smørgrav <des@FreeBSD.org> >> CommitDate: 2025-09-11 15:12:22 +0000 >> >> Revert "libc: Remove readdir_r(3)" >> >> This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4. >> >> > Hi Dag-Erling, > Could you please explain why this change was reversed? > Because the reason was missing from this commit message. > Rust breaks with this change. While rust can be fixed (and will be) since it's doing some sketch things and the fix is to just remove the sketch stuff. However, part of Rust's work flow is to do A/B testing between new runs under test, and older Rust versions. The old binaries work fine, but newly-built copies of the old versions do not. Until those old versions 'age out' of this setup, we'll be stuck with this. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Thu, Sep 11, 2025 at 10:27 AM Olivier Cochard-Labbé <<a href="mailto:olivier@freebsd.org">olivier@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:"courier new",monospace"><br></div></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 11, 2025 at 8:12 AM Dag-Erling Smørgrav <<a href="mailto:des@freebsd.org" target="_blank">des@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by des:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=d20c82507278e003f391c3fb04f4e49afd1537ab" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=d20c82507278e003f391c3fb04f4e49afd1537ab</a><br>; <br> commit d20c82507278e003f391c3fb04f4e49afd1537ab<br> Author: Dag-Erling Smørgrav <des@FreeBSD.org><br> AuthorDate: 2025-09-11 15:12:22 +0000<br> Commit: Dag-Erling Smørgrav <des@FreeBSD.org><br> CommitDate: 2025-09-11 15:12:22 +0000<br> <br> Revert "libc: Remove readdir_r(3)"<br> <br> This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4.<br><br></blockquote><div><br></div>Hi Dag-Erling,<br>Could you please explain why this change was reversed?<br>Because the reason was missing from this commit message.<br></div></div></blockquote><div><br></div><div>Rust breaks with this change. While rust can be fixed (and will be) since it's doing some sketch things and the fix is to just remove the sketch stuff. However, part of Rust's work flow is to do A/B testing between new runs under test, and older Rust versions. The old binaries work fine, but newly-built copies of the old versions do not. Until those old versions 'age out' of this setup, we'll be stuck with this.</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqqQ-vGTXYQ==J_LD6a2%2Be1GwcGmkJJ5n=4zbyS7Cd9dg>