Date: Fri, 23 Jun 2017 09:53:37 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Justin Hibbits <jrh29@alumni.cwru.edu> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, "svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org> Subject: Re: svn commit: r320156 - in head: cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzfs/common sys/cddl/contrib/opensolaris/common/zfs sys/cddl/contri... Message-ID: <8c556315-b267-54c1-049a-c401ab0d6b09@FreeBSD.org> In-Reply-To: <CAHSQbTD%2B8w3bM9cfYa_vapk2Mqo1rRqzOLNsiAJKbekHcOgyLQ@mail.gmail.com> References: <201706201739.v5KHdPhO051256@repo.freebsd.org> <CAHSQbTD%2B8w3bM9cfYa_vapk2Mqo1rRqzOLNsiAJKbekHcOgyLQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23/06/2017 06:10, Justin Hibbits wrote: > This commit breaks gcc builds with new warnings introduced: > > /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c: In function 'arc_kmem_reap_now': > /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c:4364: warning: nested extern declaration of 'abd_chunk_cache' [-Wnested-externs] > /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c: In function 'vdev_label_write_pad2': > /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c:902: > warning: passing argument 2 of 'abd_copy_from_buf' discards qualifiers from > pointer target type I missed the first one during the merge. The second one is in FreeBSD specific code, but the root cause is that the interface introduced upstream takes a non-const parameter where it should really take a const one. Thank you for the report. I'll handle this. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8c556315-b267-54c1-049a-c401ab0d6b09>