Date: Wed, 14 Mar 2018 18:50:09 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Alan Somers <asomers@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <20180314225009.gu3awgryggsxqmff@mutt-hbsd> In-Reply-To: <201802251429.w1PEThjY035303@repo.freebsd.org> References: <201802251429.w1PEThjY035303@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6hriqc5dgbphwzer Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > Author: asomers > Date: Sun Feb 25 14:29:43 2018 > New Revision: 329984 > URL: https://svnweb.freebsd.org/changeset/base/329984 >=20 > Log: > Don't declare __assfail as static > =20 > It gets called by dmu_buf_init_user, which is inline but not static. S= o it > needs global linkage itself. > =20 > Reported by: GCC-6 > MFC after: 17 days > X-MFC-With: 329722 >=20 Hey Alan, This commit breaks compiling world with ASAN. Some applications, like zfs, will fail with this error: /lib/libuutil.so.2: Undefined symbol "__assfail" Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --6hriqc5dgbphwzer Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlqppx0ACgkQaoRlj1JF bu4UmQ//UXvruRxifAAXzUyTuhNu++/qKJv1GqV7joVYk71vYfNuSz/kWtXH6G1M f9KZA8+4eK2RlvaJi/UOEWgN1MjJK2HQMu1DxtqjeuTx4i2qTD1eRHGRRO6beEdk mIh6sru587E8yFCHGefYvRq097Fc9gtyIInkU3MbdiF8avfiqbRSy+KCxUcUeo6P bH3A57XONjN8Af+B3U+L+CR1pPiwh5oWKAcFNcOKDBp7v8YdsLZQNwUccfgUNVzk DlkW3bnGU62z/qfsI4yDtNp8tgpqy22AX3Ii1WMcy0lnMM/MrXRM1yrw9MDX93ew UTlzf3Z37TlIPHdMuj+FdmNQUk6RWZl6rNiwuOaZIR47pV/FgzboEXKdWui0av4d CFtfQtYkp+Lu9vAOwV7ahy8mDNVGfVp8MZsyPH5mFzw/SkQGvnMZA8n/ciNu+8ys 12HSBHlaBh9sCvJ0fHIbdfITmYkDgwqip00yyHaET4itWz5xcpuiQvKDWNMHisKZ NvRRuzzooqO50vN9/V1fQ7Zc8Jsa9mZTqJ4w2K8wg7m4PckJhVhVR7y27m9WWBol ZX1wmwXBHnYpS7WwRAHp+fx9ELGKrxMVn9rM7v+KwIuv2sr0DI7p85QfK7503HN5 oUwkJ9dI3CZJ2UK/fAmZvia4rbMWutpFwyM5Q17Mr7WQTkjvFeQ= =8pIF -----END PGP SIGNATURE----- --6hriqc5dgbphwzer--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180314225009.gu3awgryggsxqmff>