Date: Wed, 8 Feb 2006 11:49:34 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Qing Li <qingli@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c Message-ID: <20060208084934.GJ877@FreeBSD.org> In-Reply-To: <200602071959.k17JxkXv002652@repoman.freebsd.org> References: <200602071959.k17JxkXv002652@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 07, 2006 at 07:59:46PM +0000, Qing Li wrote: Q> qingli 2006-02-07 19:59:46 UTC Q> Q> FreeBSD src repository Q> Q> Modified files: Q> sys/netinet tcp_syncache.c Q> Log: Q> Fixes a crash due to the memory of the newly allocated syncache entry Q> in syncache_lookup() is not cleared and may lead to an arbitrary and Q> bogus rtentry pointer which later gets free'd. Q> Q> Reviewed by: andre Q> MFC after: 3 days I think it will be better just pass M_ZERO flag to uma_zalloc(). Also, do same in the second uma_zalloc() call in this file. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060208084934.GJ877>