Date: Thu, 20 Apr 2017 14:06:05 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r317171 - head/sys/dev/vt Message-ID: <f7db1900-5d12-4b0d-9358-75c5aa8a9c58@FreeBSD.org> In-Reply-To: <CAPyFy2C4d9LJMME%2BSPd%2BAA1s375eFKOXyNJQYTmT6Edf1%2BCRrA@mail.gmail.com> References: <201704192221.v3JMLFPs032866@repo.freebsd.org> <CAPyFy2C4d9LJMME%2BSPd%2BAA1s375eFKOXyNJQYTmT6Edf1%2BCRrA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI Content-Type: multipart/mixed; boundary="jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <f7db1900-5d12-4b0d-9358-75c5aa8a9c58@FreeBSD.org> Subject: Re: svn commit: r317171 - head/sys/dev/vt References: <201704192221.v3JMLFPs032866@repo.freebsd.org> <CAPyFy2C4d9LJMME+SPd+AA1s375eFKOXyNJQYTmT6Edf1+CRrA@mail.gmail.com> In-Reply-To: <CAPyFy2C4d9LJMME+SPd+AA1s375eFKOXyNJQYTmT6Edf1+CRrA@mail.gmail.com> --jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 04/19/2017 22:22, Ed Maste wrote: > On 19 April 2017 at 18:21, Jung-uk Kim <jkim@freebsd.org> wrote: >> Author: jkim >> Date: Wed Apr 19 22:21:15 2017 >> New Revision: 317171 >> URL: https://svnweb.freebsd.org/changeset/base/317171 >> >> Log: >> Micro-optimize vt_set_border(). >=20 > I expect we'll eventually have vt drivers that have a non-trivial > vd_drawrect, making the previous implementation preferable. Can you > comment a bit more on this change? Maybe but I haven't seen much improvement in the area for many years. Do you have any reason to believe someone is working on it? Even if we have such backend, I don't expect much difference in drawing small area, i.e., redrawing narrow borders. On top of that, I don't like "if (vd->vd_driver->vd_drawrect =3D=3D NULL) return (ENOTSUP)" stuff= =2E Jung-uk Kim --jf1OklO0u8PlVmebFFV2M1uGAAfLQrsTc-- --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlj4+JEACgkQfJ+WJvzb 8UZoagf/TKXZZ6KWkbrn10rmyHg8P/F8ZkrKoSf3vG8LqG97VnqzQOrf5hyHvsm8 LjmYLjHAAwpQ85rcxb57YIwPNMMmz4KaP5C5ys8hVtLUq42umeTTwokHlQAQCQMu y7D8V4C8ehZY5pZj5uzowdXWdcPJrs/8V8tSydbBCYTI0YDKFynhHqjcvlhWuh2x 7Ro9z5EO09OjA3JkMGW+SWbshpqBpxO69c9gO7wba5/VkLSsJ1mGgmEGDizbvhxJ Vib67EMw1yMf90AElqIQNDLfyzvNBkk/kiYEFZfT46ULxOsmBV6rNzhM0/o1qOeN H5bj7W6p8tn1DLVkb4V0vemMi8fr5w== =IDVM -----END PGP SIGNATURE----- --D0KmnD46FDVDbQwhX8VS1ukwMSaGJh2TI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f7db1900-5d12-4b0d-9358-75c5aa8a9c58>